Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for claims request parameter #332

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ompluscator
Copy link

This commit gives support for "claims" request parameter, according to specs: https://openid.net/specs/openid-connect-core-1_0.html#ClaimsParameter

@gopherbot
Copy link
Contributor

This PR (HEAD: 5641e21) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/142137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/142137.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b92585a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/142137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@Ompluscator Ompluscator force-pushed the claims-request-parameter-squashed branch from b92585a to b762685 Compare January 21, 2019 14:13
@gopherbot
Copy link
Contributor

This PR (HEAD: b762685) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/142137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/142137.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3a2f27c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/142137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Marko Milojevic:

Patch Set 4:

(6 comments)

Hi.

I have updated code review by implementing all suggestions you mentioned. I hope this new patchset is fine.

Thank you for your feedback!


Please don’t reply on this GitHub thread. Visit golang.org/cl/142137.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 4e2fe58) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/142137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@bykof
Copy link

bykof commented Apr 12, 2021

What is the status here?

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/142137.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Marko Milojevic:

Patch Set 4:

(6 comments)

Hi.

I have updated code review by implementing all suggestions you mentioned. I hope this new patchset is fine.

Thank you for your feedback!


Please don’t reply on this GitHub thread. Visit golang.org/cl/142137.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants